| Author |
 Topic  |
|
|
Prinz
Senior Member
Germany
1522 Posts |
 Posted - 12 Sep 2010 : 01:50:42
|
I know we had already talk about this, but i think the amount of variables for the Movie Card is almost in reverse.
There are 100 (Front-)Cover Variables. But only 20 Fanart Variables. I think in Reality the probability is much higher that for one Movie or especially TV Show there are more Fanart's available than Covers.
I looked in my test database, the highest number for Cover was 48 (a rare example) and the highest number of Fanart was 89 for one TV Show. Then i looked in the thetvdb there a few Big TV Shows (House, Fringe, Smallville, Bones, Doctor Who,...) that have 60-70 and more Fanarts available.
I think i would be more realistically to reduce the number of Cover-variables (if necessary because of the performance) and increase the variables for Fanart.
Maybe some other people could write here what the highest number of Covers, Backcovers and Fanarts for one Movie/TV Show are in there Databases. |
|
|
Prinz
Senior Member
Germany
1522 Posts |
Posted - 12 Sep 2010 : 02:27:48
|
Here is just an idea to increase to performance for this many variables of one type:
Only search and replace the 3 Main-Variables in the entire HTML-Code:
_MOVIE_COVER_
_MOVIE_BACKCOVER_
_MOVIE_FANART_
The other additional variables are only searched and replaced inside these new html comment tags:
<!--START_FRONTCOVER-->
<img src="_MOVIE_COVER1_">
<img src="_MOVIE_COVER2_">
...
<img src="_MOVIE_COVER99_">
<!--END_FRONTCOVER-->
<!--START_FANART-->
<img src="_MOVIE_FANART1_">
<img src="_MOVIE_FANART2_">
...
<img src="_MOVIE_FANART99_">
<!--END_FANART-->
<!--START_BACKCOVER-->
<img src="_MOVIE_BACKCOVER1_">
<img src="_MOVIE_BACKCOVER2_">
...
<img src="_MOVIE_BACKCOVER99_">
<!--END_BACKCOVER-->
If you only search (and then replace) the variables inside this tags (only a few lines from the html code) it should be much faster even/especially with many variables.
This is just a thought and not tested, but normally logical.
PS.: I think Backcover don't need that many, the already included 10 Variables should be enough. |
Edited by - Prinz on 12 Sep 2010 02:30:07 |
 |
|
|
JDommi
Administrator
Germany
4638 Posts |
Posted - 12 Sep 2010 : 09:26:11
|
I agree to change the number of cover storage, Prinz.
For me I am using only the movie poster in _MOVIE_COVER1_ and the complete dvd cover scan in no.2 and the dvd scan in no.3.
Booklets, inlays and other posters are stored in the remaining _MOVIE_COVER_ places.
Several different dvd cover versions are not really neccesary - in my opinion.
So I would suggest to have an amount of 50 _MOVIE_COVER_, 10 _MOVIE_BACKCOVER_ and 100 _MOVIE_FANART_ places.
Maybe in future Ale could divide the three categories into POSTER COVER BACKCOVER CD/DVD's FANART and OTHER_PICS. Only difficulty on that could be to manually move from one category to another. But that would be a clear structure. |
In order to achieve what is possible, you have to try the impossible over and over again.
Hermann Hesse |
|
|
|
Alessio Viti
Forum Admin
Italy
9171 Posts |
|
|
Prinz
Senior Member
Germany
1522 Posts |
Posted - 12 Sep 2010 : 17:25:53
|
quote:
Originally posted by JDommi
Maybe in future Ale could divide the three categories into POSTER COVER BACKCOVER CD/DVD's FANART and OTHER_PICS.
I would also add BANNERS and Season BANNERS/COVERS for TV Shows. Look at the thetvdb there are many Banners/Season Banners for each show and this could also be used for many external plugins (HTPC-Software, Mediaplayer use them). |
Edited by - Prinz on 12 Sep 2010 17:26:29 |
|
|
|
JDommi
Administrator
Germany
4638 Posts |
Posted - 12 Sep 2010 : 17:41:52
|
Yep, great idea!
Seems to give Ale some more work on XMM :P
In addition to that: what about soundtrack info on the movies? Just like I already did for TV Shows (MyThemes.TV and TelevisionTunes.COM)? |
In order to achieve what is possible, you have to try the impossible over and over again.
Hermann Hesse |
|
|
|
Alessio Viti
Forum Admin
Italy
9171 Posts |
|
|
JDommi
Administrator
Germany
4638 Posts |
Posted - 04 Nov 2010 : 22:32:59
|
With the new CoverManager plugin (I think it will be available in next release) you can move easy/easier covers from one category to another.
Now I have "tinkered" a little javascript routine that can show more different picture categories than cover, backcover and fanart without the need to modify the database structure by Ale (although it would be better).
So my question: do you want that feature and which categories should be really added?
My suggestion is:
_MOVIE_POSTER_
_MOVIE_COVER_ (for DVD, Blue-ray, VHS)
_MOVIE_FRONTCOVER_ (for Jewelcase)
_MOVIE_BACKCOVER_ (for Jewelcase)
_MOVIE_CD_DVD_
_MOVIE_FANART_
_MOVIE_SCREENSHOTS_
_MOVIE_BANNERS_
_MOVIE_SEASON_BANNERS_
_MOVIE_SEASON_COVERS_
If wanted I will modify the plugin to handle those new categories, too.
Tomorrow (when I'm @home) I will post here the javascript example that will show the movie's poster. In the case that no pic exists for it will show the 1st pic of _MOVIE_COVER_.
Then the cracks like Prinz can test the routine to say if that would be an alternative to changing db structure...
|
In order to achieve what is possible, you have to try the impossible over and over again.
Hermann Hesse |
|
|
|
JDommi
Administrator
Germany
4638 Posts |
Posted - 05 Nov 2010 : 09:21:39
|
And here is the HTML code. It's not tested in any MovieCard but only in this dummy!
*edit*
Another suggestion on database structure: why storing the name of back cover and fanart instead of a boolean flag? Would save a little bit of memory and .mdb capacity. Only difference between them and the "normal" cover name is the _back/_fanart in name.
*/edit*
<html>
<head>
<title>Test</title>
</head>
<body>
<script>
// script has to go where the img should be shown:
// <img src="G:\XMM\Movies_V7\JD_V7_cover2\1-Niagara_poster.jpg" alt="Movie Poster" onError="this.src='G:/XMM/Movies_V7/JD_V7_cover2/1-Niagara.jpg';" />
// var cover = "_MOVIE_COVER_";
var cover = "G:/XMM/Movies_V7/JD_V7_cover2/1-Niagara.jpg";
var file=(/(\w+\.\w+)\s*$/.exec(cover))[1];
var file_no_ending = file.match(/([^\/]+)\.\w+$/)[1];
var apos = file_no_ending.search("_");
if (apos != -1)
{
file_no_ending = file_no_ending.substring(0, apos);
}
var mposter = cover.replace(file_no_ending, file_no_ending+"_poster");
var mystring = '<img src="' + mposter + '" alt="Movie Poster" onError="this.src=';
// mystring = mystring + "'_MOVIE_COVER_'";
mystring = mystring + "'G:/XMM/Movies_V7/JD_V7_cover2/1-Niagara_1.jpg'";
mystring = mystring + ';" />';
document.write(mystring);
</script>
</body>
</html> |
In order to achieve what is possible, you have to try the impossible over and over again.
Hermann Hesse |
Edited by - JDommi on 05 Nov 2010 09:56:32 |
|
|
|
Mawu
Senior Member
Germany
1024 Posts |
Posted - 05 Nov 2010 : 15:07:08
|
As for me I use the following categories of pictures:
Front Cover - DVD/Blu-ray front cover or special version for jewel case
Poster - original movies posters from theater release
DVD/Blu-ray Cover - complete cover
Back Cover - DVD/Blu-ray back cover or special version for jewel case
CD/DVD - picture CD/DVD (used for DVD direct cover print)
Screenshots
Fanart - all other stuff
For me it's not necessary to differentiate too much. As for XGM and XBM the Screenshot "slot" is already available it should be also integrated into XMM.
|
www.schlemmerkino.de - Die Nr.1 für filmische Leckereien |
|
|
|
Prinz
Senior Member
Germany
1522 Posts |
Posted - 05 Nov 2010 : 15:34:27
|
JDommi you gave me an idea. It's simple, too simple to have the idea before.
We don't need all the variables a multiple times. _MOVIE_COVER1_ _MOVIE_BACKCOVER1_ _MOVIE_FANART1_. One of each is enough. The others are simply (unlimited) created via javascript.
Just replacing for example all additional Movie Covers with this code:
<div align="center" id="extracover"><br>
<a id="mcov1" style="display:none;">_MOVIE_COVER1_</a>
</div>
<script type="text/javascript">
var relTo = document.getElementById ("extracover");
var fmc = $('#mcov1').text();
for (var mic = 1;mic < 200;mic++) {
relTo.insertAdjacentHTML('BeforeEnd','<img src="' + fmc.replace('_1.','_' + mic + '.') + '" onerror="ImgError2(this);" class="my_img">#013;');}
</script>
And up to 200 Covers are added in this example. Filenames are created via javascript loop.
To make that as fast as possible we just would need 3 new variables:
_MOVIE_COVER_COUNT_
_MOVIE_BACKCOVER_COUNT_
_MOVIE_FANART_COUNT_
These Variables should simply give back the number of each Imagetyp for the Movie/TV Show.
If these Variables are added to XMM we code in the example for covers could change to:
for (var mic = 1;mic < _MOVIE_COVER_COUNT_;mic++) {
And only the really existing Images would be added to the page (increased loading speed) |
Edited by - Prinz on 05 Nov 2010 21:07:48 |
|
|
|
Alessio Viti
Forum Admin
Italy
9171 Posts |
|
|
Prinz
Senior Member
Germany
1522 Posts |
|
|
Prinz
Senior Member
Germany
1522 Posts |
Posted - 09 Nov 2010 : 13:35:40
|
Is it working or not?
I need to know it for the future developing of the movie card. |
|
|
|
Alessio Viti
Forum Admin
Italy
9171 Posts |
|
|
Prinz
Senior Member
Germany
1522 Posts |
Posted - 09 Nov 2010 : 15:45:46
|
The exe you sent doesn't work. It replaces the first part with _MOVIE_COVER_COUNT_ with the picture, because that part also matches that variable.
I think we have to rename the variables for the image count for example to:
_MOVIE_COVERCOUNT_
_MOVIE_BACKCOVERCOUNT_
_MOVIE_FANARTCOUNT_
so that the magic script engine doesn't confuse the variables. |
|
|
|
Alessio Viti
Forum Admin
Italy
9171 Posts |
|
|
Prinz
Senior Member
Germany
1522 Posts |
Posted - 10 Nov 2010 : 10:35:13
|
Somehow the variables don't allways give back the correct number of Images. It seams that the numbers use the old maximum restriction. So for normal covers the number is never higher than 20 and for fanart never higher than 50.  But the should give back the real number of Images for that movie/tv show. Restricting the number of shown images is easily done on the movie cards itself with the javascript function.
PS.: Even now the loading time is noticeable faster on my pc. |
|
|
|
Alessio Viti
Forum Admin
Italy
9171 Posts |
Posted - 10 Nov 2010 : 11:30:57
|
Hello Prinz,
Yes, you are right, if you have less images you get the exact number, otherwise you get the maximum.
OK, if we are ready I will raise this number and maybe upload the new release...
How many covers I should put as maximum? Because count the number of images (i.e. check if the files exist) can take some time too, right?
Thank you
Ale |
http://www.facebook.com/pages/eXtreme-Movie-Manager/47220214342?ref=mf
 |
|
|
|
Prinz
Senior Member
Germany
1522 Posts |
Posted - 10 Nov 2010 : 11:51:08
|
quote:
Originally posted by Alessio Viti
Because count the number of images (i.e. check if the files exist) can take some time too, right?
You mean you have to check if a file exists inside XMM itself? I don't know how much time your program needs to make this checks and get the image count for the variables...
There is no need to check if the file exists inside the movie card anymore, because if the variable says there are for example 103 only these images are added via javascript to the card. That makes the loading of the card faster if there is only 1 Image only 1 is added to the Card, if there is none there is no image added to the card... If you wont to add less then the maximum to a card a simple additional check in javascript will reduce the amount of added image.
So from the Movie Card HTML javascript programing side there is no need for any restriction to that number, that won't change the loading time at all. That is the good thing about adding the images this way.
PS.: I had to change the moviecard a little bit, so don't use the test card that i upload. That has a few bugs... |
|
|
|
Alessio Viti
Forum Admin
Italy
9171 Posts |
|
|
Topic |
|
|
Number of Varibales for Cover, Backcover, Fanart