Author |
Topic |
|
JDommi
Administrator
Germany
4650 Posts |
Posted - 22 Jul 2021 : 20:47:02
|
Well, I think I have a big help in you I still was debugging the script to find the problem.
Beside that I have recognized that the Year block is still not fixed. I will later upload the fixed fixes |
In order to achieve what is possible, you have to try the impossible over and over again. Hermann Hesse |
|
|
Alferio
Starting Member
35 Posts |
Posted - 22 Jul 2021 : 20:52:24
|
It seems that runs better than before............. GREAT !!!!!!!!!!!!!!!!!!!!! |
|
|
JDommi
Administrator
Germany
4650 Posts |
|
cucucobra
Starting Member
USA
11 Posts |
Posted - 23 Jul 2021 : 02:55:35
|
I deleted and reimported about 20 movies to test out the 7th revision. The script works great!
If you are going to work on the TV show script next and need any help, please just let me know. |
|
|
JDommi
Administrator
Germany
4650 Posts |
Posted - 23 Jul 2021 : 09:04:35
|
|
In order to achieve what is possible, you have to try the impossible over and over again. Hermann Hesse |
|
|
JDommi
Administrator
Germany
4650 Posts |
Posted - 23 Jul 2021 : 09:44:44
|
Fortunately 90% of the main info of the TV Show script is identical to the normal script. There are only a few exceptions on some blocks. "Only" everything after the CreateEpisodesList has to be done more or less completely new... Maybe I will begin with fixing at the weekend or next week. |
In order to achieve what is possible, you have to try the impossible over and over again. Hermann Hesse |
|
|
robace
Starting Member
11 Posts |
Posted - 23 Jul 2021 : 13:18:17
|
I've updated all of "faulty" entries using the new script. Thanks, it's nice to get it working correctly. |
|
|
JDommi
Administrator
Germany
4650 Posts |
|
cucucobra
Starting Member
USA
11 Posts |
Posted - 23 Jul 2021 : 21:36:51
|
quote: Originally posted by JDommi
Fortunately 90% of the main info of the TV Show script is identical to the normal script. There are only a few exceptions on some blocks. "Only" everything after the CreateEpisodesList has to be done more or less completely new... Maybe I will begin with fixing at the weekend or next week.
That's great news! I'll have free time on Sunday to work on any bugs you're having difficulty with. Hopefully the code syntax used is similar, since I've figured out how that works (mostly... sometimes it still seems like magic, lol). |
|
|
JDommi
Administrator
Germany
4650 Posts |
Posted - 23 Jul 2021 : 22:07:56
|
Any help is really appriciated! I think I haven't really fixed any script since 3 years...
If you are interested in the whole technique I suggest to read http://www.binaryworks.it/forum/topic.asp?TOPIC_ID=15900 Beside that I am using the Script Debugger instead of the MagicScript Editor. It's a little slower but you have a more comfortable Editor. Mostly everything of the script is to find unique HTML code and extract the specific info. Constructions like IF and WHILE a simple loops. Unfortunately there are missing string functions for easy manipulating the content of a variable and real subroutines called by GOSUB. At least the subroutines are possible in the way I have implemented the whole actor's info. |
In order to achieve what is possible, you have to try the impossible over and over again. Hermann Hesse |
|
|
JDommi
Administrator
Germany
4650 Posts |
|
JDommi
Administrator
Germany
4650 Posts |
|
washandgo
Junior Member
Spain
257 Posts |
Posted - 25 Jul 2021 : 11:47:51
|
There is life !!! Is it a dream? Will we use the forum again? Do I remove the dust and start the machines? By the way, good morning everyone
|
|
|
de66ka
Starting Member
27 Posts |
Posted - 25 Jul 2021 : 12:09:41
|
Impressive, thanks for the work |
|
|
JDommi
Administrator
Germany
4650 Posts |
Posted - 25 Jul 2021 : 12:40:42
|
It's only self-interest
V4 - IMDB (TVSeries): https://www.mediafire.com/file/937g0l7x4br464c/4S_IMDB.COM_%2528TVSeries%2529_For_Rel.8.txt/file
Still not everything but the most important info is available now. But enough for today as I have to go to work in 2 hours
Btw. it seems as if some info can't be taken for episodes as example the episoderating... |
In order to achieve what is possible, you have to try the impossible over and over again. Hermann Hesse |
|
|
jimini
Starting Member
United Kingdom
20 Posts |
Posted - 25 Jul 2021 : 14:31:40
|
quote: Originally posted by JDommi
It's only self-interest
V4 - IMDB (TVSeries): https://www.mediafire.com/file/937g0l7x4br464c/4S_IMDB.COM_%2528TVSeries%2529_For_Rel.8.txt/file
Still not everything but the most important info is available now. But enough for today as I have to go to work in 2 hours
Btw. it seems as if some info can't be taken for episodes as example the episoderating...
Hi, firstly thanks for your hard work. I have noticed a problem with importing the Director on certain series.. example is Takki where the script seems to go on an endless loop and will run until it is forced to stop the script engine. Just for info. Many thanks once again |
|
|
JDommi
Administrator
Germany
4650 Posts |
Posted - 25 Jul 2021 : 15:03:40
|
Well, the problem is that an info is missing. In this case the creator of the show. try to change one line in the script, please: Line 1336 - toggle the #ONERROR# parameter from *OK* to *STOP*
:ENDTAKEDIRECTOR
#RESTOREMAIN#
#STARTREADWEB#
#FINDLINE#="creator":[{#12##ONERROR#=*STOP*
Sorry, but I'm @work now and can't check it out myself... |
In order to achieve what is possible, you have to try the impossible over and over again. Hermann Hesse |
|
|
jimini
Starting Member
United Kingdom
20 Posts |
Posted - 25 Jul 2021 : 15:20:03
|
quote: Originally posted by JDommi
Well, the problem is that an info is missing. In this case the creator of the show. try to change one line in the script, please: Line 1336 - toggle the #ONERROR# parameter from *OK* to *STOP*
:ENDTAKEDIRECTOR
#RESTOREMAIN#
#STARTREADWEB#
#FINDLINE#="creator":[{#12##ONERROR#=*STOP*
Sorry, but I'm @work now and can't check it out myself...
Thankyou.. Seems to be working now. |
|
|
JDommi
Administrator
Germany
4650 Posts |
Posted - 25 Jul 2021 : 15:29:31
|
Great |
In order to achieve what is possible, you have to try the impossible over and over again. Hermann Hesse |
|
|
cucucobra
Starting Member
USA
11 Posts |
Posted - 25 Jul 2021 : 18:36:42
|
quote: Originally posted by JDommi
Any help is really appriciated! I think I haven't really fixed any script since 3 years...
If you are interested in the whole technique I suggest to read http://www.binaryworks.it/forum/topic.asp?TOPIC_ID=15900 Beside that I am using the Script Debugger instead of the MagicScript Editor. It's a little slower but you have a more comfortable Editor. Mostly everything of the script is to find unique HTML code and extract the specific info. Constructions like IF and WHILE a simple loops. Unfortunately there are missing string functions for easy manipulating the content of a variable and real subroutines called by GOSUB. At least the subroutines are possible in the way I have implemented the whole actor's info.
Thanks for the tips! They were very helpful. The script is looking great and imports everything I care about (I don't really care much for individual episode information, as I care more about looking up the info on an entire TV series).
I've played around for a few hours and the episode information is a lot more complex, but I was able to make the following changes, which were preventing the individual episode titles from importing correctly:
-----
Replaced the following on like 960:
#GOTO#=DONTTAKEEPACTOR //replaced DONTTAKEEPACTOR1 WITH DONTTAKEEPACTOR, as first reference does not exist in code
Commented out lines 3649-3659 below, as ENDTAKEEPACTORS reference missing from code:
//#IF# #11#==#00# // #GOTO#=ENDTAKEEPACTORS //#ENDIF# //#IF# #68#==#00# // #GOTO#=ENDTAKEEPACTORS //#ENDIF#
Commented out line 3733 below, as ENDTAKEEPACTORS reference missing from code: //#GOTO#=ENDTAKEEPACTORS
-----
Getting each individual episode plot to import isn't going well for me at the moment, but I'll drop a post if I have any luck. :) |
|
|
Topic |
|
|